lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4423) DocumentStoredFieldVisitor.binaryField ignores offset and length
Date Tue, 25 Sep 2012 10:58:08 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462642#comment-13462642
] 

Robert Muir commented on LUCENE-4423:
-------------------------------------

{quote}
although I am not sure whether it should be the responsability of the StoredFieldVisitor or
of the StoredFieldsReader to make sure that the byte[] is a copy (this patch assumes it it
the responsability of StoredFieldVisitor).
{quote}

Can we separate this? This is a different issue (there are TODOs about that). I definitely
dont want it mixed in with this bugfix.
                
> DocumentStoredFieldVisitor.binaryField ignores offset and length
> ----------------------------------------------------------------
>
>                 Key: LUCENE-4423
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4423
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/store
>            Reporter: Adrien Grand
>         Attachments: LUCENE-4423.patch
>
>
> This is no problem with SimpleText and Lucene40 since in their cases, offset is always
0 and length the length of the byte[] array, but it might break with custom codecs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message