lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <>
Subject [jira] [Commented] (LUCENE-4384) add top-level 'ant precommit'
Date Thu, 13 Sep 2012 20:31:07 GMT


Robert Muir commented on LUCENE-4384:

It seems to me the problems you have are related to IDEA using build/ ?

I looked at the config and it seems its output directories are in fact lucene/build ?
    <output url="file://$MODULE_DIR$/../../../build/core/classes/java" />
    <output-test url="file://$MODULE_DIR$/../../../build/core/classes/test" />

I think this is a significant risk: if someone with this IDE were to build a release it could
be completely different than what we expect (include extra stuff or missing some stuff), or
even just act strange because bytecode was compiled by something like the ecj compiler unexpectedly?

> add top-level 'ant precommit'
> -----------------------------
>                 Key: LUCENE-4384
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Task
>          Components: general/build
>            Reporter: Robert Muir
>         Attachments: LUCENE-4384.patch
> We have a lot more checks in the build:
> If we added 'ant precommit' it would make it easier to run all the (reasonably fast)
checks beforehand... and save some typing.
> So I think we can just add precommit which is:
> * check-svn-working-copy (looks for un-added files, wrong eol-style)
> * validate (nocommit/author checks, license headers, 3rd party licenses, forbidden apis)
> * javadocs-lint (javadocs + missing/broken links checks)
> * test

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message