lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <>
Subject [jira] [Commented] (LUCENE-4443) BlockPostingsFormat writes unnecessary skipdata
Date Fri, 28 Sep 2012 12:51:07 GMT


Robert Muir commented on LUCENE-4443:

Me too, lets leave that be. For now I committed this patch.

I bumped the codec header version so anyone testing Block already gets a clean error.
> BlockPostingsFormat writes unnecessary skipdata
> -----------------------------------------------
>                 Key: LUCENE-4443
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/codecs
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>             Fix For: 4.1
>         Attachments: LUCENE-4443.patch
> Seems to me lastStartOffset is unnecessary, when we skip to a document, it implicitly
is 0: see BlockPostingsWriter.startDoc.
> (Unless I'm missing something, all tests pass with "Block" if i remove it)
> Separately we should really think about lastPayloadByteUpto, is this worth it? instead
when we actually skip, we could sum the payloadLengthBuffer from 0..curPosBufferUpto as we
are going to decode that block anyway?

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message