lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4377) consolidate various copyBytes() methods
Date Wed, 12 Sep 2012 11:24:07 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453902#comment-13453902
] 

Uwe Schindler commented on LUCENE-4377:
---------------------------------------

+1, this annoyed me since long time!
                
> consolidate various copyBytes() methods
> ---------------------------------------
>
>                 Key: LUCENE-4377
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4377
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>             Fix For: 5.0, 4.0
>
>         Attachments: LUCENE-4377.patch
>
>
> Spinoff of LUCENE-4371:
> {quote}
> I don't think the default impl (SlicedIndexInput) should overrided BII's copyBytes? Seems
... spooky.
> {quote}
> There are copyBytes everywhere, mostly not really being used.
> Particularly DataOutput.copyBytes(DataInput) versus IndexInput.copyBytes(IndexOutput).
> Bulk merging already uses DataOutput.copyBytes(DataInput), its the most general (as it
works on DataInput/Output), and its in dst, src order.
> I think we should remove IndexInput.copyBytes, its not necessary.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message