lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4419) Test RecursivePrefixTree indexing non-point data
Date Mon, 24 Sep 2012 01:45:07 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461561#comment-13461561
] 

David Smiley commented on LUCENE-4419:
--------------------------------------

I'm all for what you suggest -- a test that could be used by multiple strategies.  We're doing
that already in fact in PortedSolr3Test.  And the StrategyTestCase has methods that facilitate
using test files of sample data, which is used by several tests such as TestPointVectorStrategy.

bq. I really don't see the benefit of randomly generating Shapes.

I could have sworn you told me we should add that to the Spatial4j todo list.

I like randomized tests because it can catch errors that a static test simply didn't test
for.  This helped out tremendously when I worked out the bugs in Circle-Rectangle intersection
in Spatial4j.

                
> Test RecursivePrefixTree indexing non-point data
> ------------------------------------------------
>
>                 Key: LUCENE-4419
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4419
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial
>            Reporter: David Smiley
>
> RecursivePrefixTreeFilter was modified in ~July 2011 to support spatial filtering of
non-point indexed shapes.  It seems to work when playing with the capability but it isn't
tested.  It really needs to be as this is a major feature.
> I imagine an approach in which some randomly generated rectangles are indexed and then
a randomly generated rectangle is queried.  The right answer can be calculated brute-force
and then compared with the filter.  In order to deal with shape imprecision, the randomly
generated shapes could be generated to fit a course grid (e.g. round everything to a 1 degree
interval).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message