lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-3879) war file has javax.servlet-api jar bundled
Date Mon, 24 Sep 2012 21:06:10 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462132#comment-13462132
] 

Robert Muir commented on SOLR-3879:
-----------------------------------

Roman your patch looks good. 

smokeTestRelease.py (in the dev-tools/scripts directory) is a way to verify release artifacts.

Its like a test for the release packaging itself, so it takes as input a URL containing a
release candidate (such as http://s.apache.org/lusolr40rc0),
and runs a bunch of tests on the files there and fails if something is wrong.

It can also be run against the current code checkout by running 'ant nightly-smoke' from the
top-level.

The key here is, if we don't test that the war doesn't contain stuff it shouldn't, then the
bug could come back for a future release.

                
> war file has javax.servlet-api jar bundled
> ------------------------------------------
>
>                 Key: SOLR-3879
>                 URL: https://issues.apache.org/jira/browse/SOLR-3879
>             Project: Solr
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 4.0
>            Reporter: Roman Shaposhnik
>            Priority: Critical
>             Fix For: 4.0
>
>         Attachments: SOLR-3879.patch.txt
>
>
> This is incorrect and can lead to deployment issues:
> {noformat}
> Servlet Spec 2.5
> SRV.9.7.2 Web Application Class Loader
> The class loader that a container uses to load a servlet in a WAR must
> allow the developer to load any resources contained in library JARs
> within the WAR following normal J2SE semantics using getResource. As
> described in the J2EE license agreement, servlet containers that are
> not part of a J2EE product should not allow the application to
> override J2SE platform classes, such as those in the java.* and
> javax.* namespaces, that J2SE does not allow to be modified. Also,
> servlet containers that are part of a J2EE product should not allow
> the application to override J2SE or J2EE platform classes, such as
> those in java.* and javax.* namespaces, that either J2SE or J2EE do
> not allow to be modified. The container should not allow applications
> to override or access the container’s implementation
> {noformat}
> The fix is pretty easy and it would be nice to include it in the upcoming release of
Solr 4.0

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message