lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LUCENE-4430) Lucene Demo module should not ship with servlet-api.jar file
Date Tue, 25 Sep 2012 22:08:53 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-4430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Uwe Schindler updated LUCENE-4430:
----------------------------------

    Attachment: LUCENE-4430.patch

Simple patch.

I have seen the checker does not check all solr JARs, too. It only checks the WAR file. But
the binary dir should also not contain those files, except in the example folder.
                
> Lucene Demo module should not ship with servlet-api.jar file
> ------------------------------------------------------------
>
>                 Key: LUCENE-4430
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4430
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/other
>    Affects Versions: 4.0-BETA
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>            Priority: Blocker
>             Fix For: 4.1, 5.0, 4.0
>
>         Attachments: LUCENE-4430.patch
>
>
> As noted in SOLR-3879, Mike's new check in the smoketester found out that Lucene's binary
release ships with a servlet-api.jar file in the Lucene demo module. This file is an interface-only
file and is provided by the servlet container where you would run the webapp.
> This file should be removed from the binary release (the License is also questionable,
because the "original" Sun License of servlet-api.jar was CDDL, although thats unimportant
because it is an API definition file and not a implementation with actual program code. Shipping
any binary code with servlet-api.jar is as wrong as shipping a Java project with JDK's rt.jar
bundled).
> In general we should (in another issue) restructure our lib folders and differentiate
(using IVY configs) between compile-time dependencies and run-time dependencies. Servlet-api.jar
is a typical example for a pure-compile-time dep.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message