lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martijn van Groningen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3997) join module should not depend on grouping module
Date Mon, 17 Sep 2012 08:40:08 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456882#comment-13456882
] 

Martijn van Groningen commented on LUCENE-3997:
-----------------------------------------------

Steven, I think this is a good idea for the reasons you mentioned. I think the new shared
module should be named 'parent-child'. This name describes the overlapping functionality both
existing modules have.
 
Directory layout:
{code}
-- lucene
|
|--- parent-child
|         |
|         |--- grouping
|         |
|         |--- join
|
|--- ...
{code}          
                
> join module should not depend on grouping module
> ------------------------------------------------
>
>                 Key: LUCENE-3997
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3997
>             Project: Lucene - Core
>          Issue Type: Task
>    Affects Versions: 4.0-ALPHA
>            Reporter: Robert Muir
>             Fix For: 4.1
>
>         Attachments: LUCENE-3997.patch, LUCENE-3997.patch
>
>
> I think TopGroups/GroupDocs should simply be in core? 
> Both grouping and join modules use these trivial classes, but join depends on grouping
just for them.
> I think its better that we try to minimize these inter-module dependencies.
> Of course, another option is to combine grouping and join into one module, but
> last time i brought that up nobody could agree on a name. 
> Anyway I think the change is pretty clean: its similar to having basic stuff like Analyzer.java
in core,
> so other things can work with Analyzer without depending on any specific implementing
modules.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message