lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martijn van Groningen (JIRA)" <>
Subject [jira] [Commented] (LUCENE-3997) join module should not depend on grouping module
Date Mon, 17 Sep 2012 08:40:08 GMT


Martijn van Groningen commented on LUCENE-3997:

Steven, I think this is a good idea for the reasons you mentioned. I think the new shared
module should be named 'parent-child'. This name describes the overlapping functionality both
existing modules have.
Directory layout:
-- lucene
|--- parent-child
|         |
|         |--- grouping
|         |
|         |--- join
|--- ...
> join module should not depend on grouping module
> ------------------------------------------------
>                 Key: LUCENE-3997
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Task
>    Affects Versions: 4.0-ALPHA
>            Reporter: Robert Muir
>             Fix For: 4.1
>         Attachments: LUCENE-3997.patch, LUCENE-3997.patch
> I think TopGroups/GroupDocs should simply be in core? 
> Both grouping and join modules use these trivial classes, but join depends on grouping
just for them.
> I think its better that we try to minimize these inter-module dependencies.
> Of course, another option is to combine grouping and join into one module, but
> last time i brought that up nobody could agree on a name. 
> Anyway I think the change is pretty clean: its similar to having basic stuff like
in core,
> so other things can work with Analyzer without depending on any specific implementing

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message