lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sami Siren (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-3768) add some prelim assertions to OverseerTest
Date Thu, 30 Aug 2012 06:14:08 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444717#comment-13444717
] 

Sami Siren commented on SOLR-3768:
----------------------------------

+1
                
> add some prelim assertions to OverseerTest
> ------------------------------------------
>
>                 Key: SOLR-3768
>                 URL: https://issues.apache.org/jira/browse/SOLR-3768
>             Project: Solr
>          Issue Type: Test
>            Reporter: Hoss Man
>         Attachments: SOLR-3768.patch
>
>
> There isn't much i understand about OverseerTest, but today while doing a full test run
I got an unreproducible assertion failure from this line...
> {noformat}
> assertNotNull("could not find counter for shard:" + ids[i], ai);
> {noformat}
> ...in which the assertion message indicated that not only was "ai" null, but "ids[i]"
was null as well.
> Poking arround the test a bit, i think what's happening here is that some of the preliminary
logic in testShardAssignmentBigger has bounded wait loops to "make sure ...." things have
happened, but there is no assertion that these things actually happen if that the loop bound
is exhausted - which can lead to missleading/confusing errors further on in the test.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message