lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrien Grand (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4322) Can we make oal.util.packed.BulkOperation* smaller?
Date Thu, 23 Aug 2012 08:57:42 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440157#comment-13440157
] 

Adrien Grand commented on LUCENE-4322:
--------------------------------------

Having a specialized encode can be important for GrowableWriter performance (this method is
used every time the number of bits per value needs to be changed).

Now that BulkOperation.java has been splitted, I think everything compiles under Maven and
Intellij (?). Why do we still need to make these files smaller?

If we really need to make these classes smaller, maybe we could first stop specializing encode
for int[] values when bitsPerValue > 32. I can't think of a use-case this method could
be useful to.
                
> Can we make oal.util.packed.BulkOperation* smaller?
> ---------------------------------------------------
>
>                 Key: LUCENE-4322
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4322
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Michael McCandless
>             Fix For: 5.0, 4.0
>
>
> These source files add up to a lot of sources ... it caused problems when compiling under
Maven and InteliJ.
> I committed a change to make separates files, but in aggregate this is still a lot ...
> EG maybe we don't need to specialize encode?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message