lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4335) Builds should regenerate all generated sources
Date Fri, 31 Aug 2012 16:20:07 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446089#comment-13446089
] 

Robert Muir commented on LUCENE-4335:
-------------------------------------

Cool, i think it would be convenient for the long term: in the short
term I think we can still try to make some progress here towards something
along the lines of an 'ant regenerate'. 

I am thinking the easiest way is to just add a 'regenerate' task to 
common-build.xml that is a no-op by default, and then each module can do 
what it needs to do?

Then we would just call it across the build.

I think we should try to regenerate as much as possible (data too) when 
we do this: e.g. kuromoji would call 'build-dict', icu module would
regenerate its stuff, and so on.

                
> Builds should regenerate all generated sources
> ----------------------------------------------
>
>                 Key: LUCENE-4335
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4335
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>         Attachments: LUCENE-4335.patch
>
>
> We have more and more sources that are generated programmatically (query parsers, fuzzy
levN tables from Moman, packed ints specialized decoders, etc.), and it's dangerous because
developers may directly edit the generated sources and forget to edit the meta-source.  It's
happened to me several times ... most recently just after landing the BlockPostingsFormat
branch.
> I think we should re-gen all of these in our builds and fail the build if this creates
a difference.  I know some generators (eg JavaCC) embed timestamps and so always create mods
... we can leave them out of this for starters (or maybe post-process the sources to remove
the timestamps) ...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message