lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-3699) SolrIndexWriter constructor leaks Directory if Exception creating IndexWriterConfig
Date Wed, 29 Aug 2012 21:04:07 GMT

     [ https://issues.apache.org/jira/browse/SOLR-3699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Hoss Man updated SOLR-3699:
---------------------------

    Attachment: SOLR-3699.patch

updated patch to trunk.

Doing this helped uncover another (distinct) case where directories were not being closed
that was exposed by the test SOLR-3746 added: if the updateHandler fails to init, then nothing
in SolrCore was closing the directoryfactory.

I'd asked miller to review this earlier, but i'm going to assume CTR soon unless i hear objections.
                
> SolrIndexWriter constructor leaks Directory if Exception creating IndexWriterConfig
> -----------------------------------------------------------------------------------
>
>                 Key: SOLR-3699
>                 URL: https://issues.apache.org/jira/browse/SOLR-3699
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Robert Muir
>            Assignee: Mark Miller
>             Fix For: 4.0
>
>         Attachments: SOLR-3699.patch, SOLR-3699.patch, SOLR-3699.patch, SOLR-3699.patch
>
>
> in LUCENE-4278 i had to add a hack to force SimpleFSDir for CoreContainerCoreInitFailuresTest,
because it doesnt close its Directory on certain errors.
> This might indicate a problem that leaks happen if certain errors happen (e.g. not handled
in finally)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message