lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] [Reopened] (LUCENE-4317) Field.java does not reuse its inlined Keyword-TokenStream
Date Wed, 22 Aug 2012 19:06:42 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Uwe Schindler reopened LUCENE-4317:
-----------------------------------


I reopen this one to fix a second reuse problem:
- It does not reuse the StringReader like Lucene 3.x did. If you look at the source code of
StringReader in JDK, you are afraid of all synchronization and cost of initialization. In
Lucene 3.x we had ReuseableStringReader, I will revive that in Field.java
- Also the AttributeSource keeps a hard reference to the String. It should free the String
on close. The above ReusableStringReader does that.
                
> Field.java does not reuse its inlined Keyword-TokenStream
> ---------------------------------------------------------
>
>                 Key: LUCENE-4317
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4317
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/index
>    Affects Versions: 4.0-BETA
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 5.0, 4.0
>
>         Attachments: LUCENE-4317.patch
>
>
> Field.java contains a inlined Keyword-TokenStream. Unfortunately this one is recreated
all the time, although one reuses the same Field instance. For NumericTokenStream Field.java
reuses it, but the Keyword one not.
> We should apply the same logic and lazy init the TokenStream with a setter for the String
value and reset(). This would be looking identical to SetNumeric(xx).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message