lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <>
Subject [jira] [Commented] (LUCENE-4304) Remove PayloadProcessProvider
Date Tue, 14 Aug 2012 06:36:37 GMT


Shai Erera commented on LUCENE-4304:

Patch looks good. One minor comment -- OrdinalMappingAtomicReader javadocs refer to LuceneTaxonomyWriter,
which is now DirectoryTaxonomyWriter (I guess it's a copy-paste error from FacetPPP).

+1 to commit.

> Remove PayloadProcessProvider
> -----------------------------
>                 Key: LUCENE-4304
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Michael McCandless
>         Attachments: LUCENE-4304.patch, LUCENE-4304.patch
> Now that we have pluggable codecs (well, PostingsFormat), an app should use a custom
PostingsFormat if it really must change payloads while merging.
> Alternatively, use a FilteredIndexReader to modify anything during addIndexes (eg the
facets use case, modifying payloads).
> Since this capability can be handled by existing more-generic functions I don't see why
we need to keep PPP around in core.  PPP is also fragile because an app generally has no visibility
on when a merge commits so it can't know if the payloads it retrieves are pre or post PPP.
> I think merging shouldn't change postings as a side-effect (by default, anyway, since
a custom PF can of course override merge and do whatever it wants).

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message