lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4278) Tests no longer check directories are closed
Date Wed, 01 Aug 2012 00:50:35 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426252#comment-13426252
] 

Hoss Man commented on LUCENE-4278:
----------------------------------

bq. I tried cleaning up for the test, it didnt work, its still leaving a directory unclosed.
I think under some exceptional conditions, the dir is not closed.

That would totally make sense -- as i mentioned in SOLR-3634 ...

bq. "Directory not closed" - something about this test is causing MockDirWrapper to complain
it's never closed - buti don't think this is a bug in the new code or the test. I suspect
we have an existing bug where SolrCore initialization failures after the Directory has already
been opened aren't closing the Directory – so we should get to hte bottom of that (probably
in a new issue if i'm correct)

...and then later on in that issue...

bq. the directory not closed problem vanished on it's own – i suspect SOLR-3656 fixed it.

...but based on your comments, it sounds like what actually happened was that LUCENE-4243
broke the close checks and the test just started being silent about the problem.

                
> Tests no longer check directories are closed
> --------------------------------------------
>
>                 Key: LUCENE-4278
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4278
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>             Fix For: 4.0, 5.0
>
>         Attachments: LUCENE-4278.patch
>
>
> I was surprised when writing a test, and forgetting to close my directory,
> that it didnt fail the test.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message