lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dawid Weiss (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4321) java.io.FilterReader considered harmful
Date Wed, 22 Aug 2012 06:30:38 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439309#comment-13439309
] 

Dawid Weiss commented on LUCENE-4321:
-------------------------------------

Yeah, this looks good to me! I'd even make "in" final, but maybe I'm paranoid and we shouldn't
limit the possibility of replacing it with something else, don't know.
{code}
// make this final?
+  protected Reader in;
{code}

I like it much better than subclassing FilterReader. I'm sure it will save many people debugging
time if they already have custom char filters.

+1 from me.
                
> java.io.FilterReader considered harmful
> ---------------------------------------
>
>                 Key: LUCENE-4321
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4321
>             Project: Lucene - Core
>          Issue Type: Bug
>    Affects Versions: 4.0-BETA
>            Reporter: Robert Muir
>             Fix For: 5.0, 4.0
>
>         Attachments: LUCENE-4321.patch
>
>
> See Dawid's email: http://find.searchhub.org/document/64b0a28c53faf39
> Reader.java is fine, it has lots of methods like read(), read(char[]), read(CharBuffer),
skip(), but these all have default implementations delegating to read(char[], int, int).
> Unfortunately FilterReader delegates too many unnecessary things such as read() and skip()
in a broken way. It should have just left these alone.
> This can cause traps for someone upgrading because they have to override multiple methods,
when read(char[], int, int) should be enough, and all Reader methods will then work correctly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message