lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <>
Subject [jira] [Commented] (LUCENE-4303) Analysis factories should use ResourceLoader, not Class.forName
Date Mon, 13 Aug 2012 21:08:38 GMT


Uwe Schindler commented on LUCENE-4303:

Patch looks fine, I dont like the newInstance().getClass(), but as quick fix this is fine.
In my opinion, the getEncoder() should request the encoder from ReosurceLoader. But its also
fine how it is implemented at the moment.

Some minor things: the inject field should have no access modifier, as test is in same package,
so package-private is fine. Protected means access from subclasses, which is not the case.

The tests are also fine, ClassPathResourceLoader is fine here!
> Analysis factories should use ResourceLoader, not Class.forName
> ---------------------------------------------------------------
>                 Key: LUCENE-4303
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/analysis
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Minor
>         Attachments: LUCENE-4303_Use_ResourceLoader_not_class_forName.patch
> This affects SnowballPorterFilterFactory and PhoneticFilterFactory.
> In Solr I encountered this problem when I specified an encoder and I was forced to put
the library in WEB-INF/lib instead of /solr/lib/.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message