lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael McCandless <luc...@mikemccandless.com>
Subject Re: svn commit: r1360205 - /lucene/dev/trunk/lucene/core/src/test/org/apache/lucene/index/TestCodecs.java
Date Wed, 11 Jul 2012 15:31:52 GMT
On Wed, Jul 11, 2012 at 11:13 AM, Robert Muir <rcmuir@gmail.com> wrote:
> I worry about real code (e.g. scorers) doing this too.
>
> Its also difficult to debug when a test does this: I think we had this
> problem with calling TermsEnum.next() after the enumeration was over
> before, and it looks really scary.
>
> We already have reader wrapping in LuceneTestcase.maybeWrapReader.
>
> I think it would be nice to have an AssertingReader added here: an FIR
> that wrapped the Fields instance and asserted all these various
> contracts we have in place to catch bad consumers.

+1

Mike McCandless

http://blog.mikemccandless.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message