lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Male (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4044) Add NamedSPILoader support to TokenizerFactory, TokenFilterFactory and CharFilterFactory
Date Tue, 24 Jul 2012 13:16:34 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421387#comment-13421387
] 

Chris Male commented on LUCENE-4044:
------------------------------------

bq. Can we include this into the SPILoader itsself? So when it finds a name which looks like
a full class name (but does not exist in the service list) it tries to Class.forName.asSubClass(clazz)
it and instantiate it in newInstance(). The replacement of solr. to something else should
be maybe done in Solr as name-preprocessing. Maybe that's too much magic, just an idea.

I'm experimenting with code that kind of does that.  It does some pre-processing of the name
before passing it of to the SPI Loader, but then it just falls back to existing behavior for
simplicity (all inside the Solr side of the code).
                
> Add NamedSPILoader support to TokenizerFactory, TokenFilterFactory and CharFilterFactory
> ----------------------------------------------------------------------------------------
>
>                 Key: LUCENE-4044
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4044
>             Project: Lucene - Core
>          Issue Type: Sub-task
>          Components: modules/analysis
>            Reporter: Chris Male
>             Fix For: 4.0
>
>         Attachments: LUCENE-4044.patch
>
>
> In LUCENE-2510 I want to move all the analysis factories out of Solr and into the directories
with what they create.  This is going to hamper Solr's existing strategy for supporting {{solr.*}}
package names, where it replaces {{solr}} with various pre-defined package names.  One way
to tackle this is to use NamedSPILoader so we simply look up {{StandardTokenizerFactory}}
for example, and find it wherever it is, as long as it is defined as a service.  This is similar
to how we support Codecs currently.
> As noted by Robert in LUCENE-2510, this would also have the benefit of meaning configurations
could be less verbose, would aid in fully decoupling the analysis module from Solr, and make
the analysis factories easier to interact with.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message