lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-3594) SolrCore() doesn't wait SolrCore.getSearcher() to register _searcher
Date Wed, 04 Jul 2012 14:34:36 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406556#comment-13406556
] 

Yonik Seeley commented on SOLR-3594:
------------------------------------

The test could just do a simple search and that would ensure that the searcher was registered
before proceeding.

The real question here is unrelated to tests: should the SolrCore constructor should wait
for a searcher to be registered before returning?
                
> SolrCore() doesn't wait SolrCore.getSearcher() to register _searcher
> --------------------------------------------------------------------
>
>                 Key: SOLR-3594
>                 URL: https://issues.apache.org/jira/browse/SOLR-3594
>             Project: Solr
>          Issue Type: Bug
>          Components: clients - java
>    Affects Versions: 3.4
>            Reporter: Egor Pahomov
>            Priority: Minor
>              Labels: test
>         Attachments: 3594.patch, testSearchersManagement.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> SolrCore() executes SolrCore.getSearcher(...) and returns without checking if getSearcher(...)
already registered _searcher. As result: if we have SolrEventListener with slow newSearcher(),
we can end test before _searcher registered and get then searcher closes and searcher opens
doesn't match. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message