lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-3304) Add Solr support for the new Lucene spatial module
Date Mon, 02 Jul 2012 20:11:36 GMT

     [ https://issues.apache.org/jira/browse/SOLR-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

David Smiley updated SOLR-3304:
-------------------------------

    Attachment: SOLR-3304_Solr_fields_for_Lucene_spatial_module.patch

Here is an updated patch.

Even though Lucene spatial now has most/all of the tests that were in this patch, I feel they
were short enough to just keep them here as well, in their Solr form, to demonstrate how to
do queries at the Solr level.

Changes:
* Account for the Spatial4j query package moving to Lucene Spatial
* Added SpatialRecursivePrefixTreeFieldType into the example schema.xml registered with name
"location_2d_trie" -- comments on name?
* Removed the old GeoHashField from the example schema.xml
* One Test file: TestSolr4Spatial that is parameterized for 3 geo fields with varying configuration.
* Added test for lat,lon order in results (which is a known failure right now).

Left to do:
* Ensure output field is lat,lon order for a geospatial context.  This should be addressed
in Lucene Spatial *or* Spatial4j but probably not here, I feel.  Comments?
* Test 2d (non-geo) spatial.  Ugh.  I'd probably do another test file with similar tests,
perhaps fewer.
* Fix "distErrPct" taking a fraction and not a percent. This problem is in Lucene spatial.

Concerns:
* The TwoDoubles type is not tested here. If I were to add it, it would surely break as it
can't handle circles and probably has other problems.  Thoughts, Ryan? I know you wrote that
one.
* Consider moving the factory stuff out of Lucene spatial into the Solr adapters?  I put them
in Lucene spatial because I was thinking of the bigger picture of clients other than Solr
that might use the same name-value initialization parameters.  Chris doesn't seem to be a
fan because the least-common-denominator way I represented this is a Map<String,String>
which is admittedly dirtly.
                
> Add Solr support for the new Lucene spatial module
> --------------------------------------------------
>
>                 Key: SOLR-3304
>                 URL: https://issues.apache.org/jira/browse/SOLR-3304
>             Project: Solr
>          Issue Type: New Feature
>    Affects Versions: 4.0
>            Reporter: Bill Bell
>            Assignee: David Smiley
>              Labels: spatial
>         Attachments: SOLR-3304_Solr_fields_for_Lucene_spatial_module.patch, SOLR-3304_Solr_fields_for_Lucene_spatial_module.patch
>
>
> Get the Solr spatial module integrated with the lucene spatial module.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message