lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4099) Remove generics from SpatialStrategy and remove SpatialFieldInfo
Date Wed, 04 Jul 2012 03:06:34 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406250#comment-13406250
] 

David Smiley commented on LUCENE-4099:
--------------------------------------

It occurred to me that if Strategy is going to contain the field name, then it might as well
contain isStored() & isIndexed() as well.

On the Solr side, I imagine the field type would do a lookup in a small HashMap of fieldName->Strategy.
 I'm not sure what the concurrency model is but I figure it needs to be thread-safe.
                
> Remove generics from SpatialStrategy and remove SpatialFieldInfo
> ----------------------------------------------------------------
>
>                 Key: LUCENE-4099
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4099
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: modules/spatial
>            Reporter: Chris Male
>            Assignee: David Smiley
>            Priority: Minor
>         Attachments: LUCENE-4099_remove_SpatialFieldInfo_and_put_fieldName_into_Strategy_instead_of_methods.patch
>
>
> Same time ago I added SpatialFieldInfo as a way for SpatialStrategys to declare what
information they needed per request.  This meant that a Strategy could be used across multiple
requests.  However it doesn't really need to be that way any more, Strategies are light to
instantiate and the generics are just clumsy and annoying.
> Instead Strategies should just define what they need in their constructor. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message