lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Male (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4188) Storing Shapes shouldn't be Strategy dependent
Date Wed, 04 Jul 2012 13:36:34 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406513#comment-13406513
] 

Chris Male commented on LUCENE-4188:
------------------------------------

bq. if the Strategy gives it to Lucene to index, can the caller (e.g. Solr / the user of the
API) add it by the same name as stored?

I think the Strategy should continue to return the Fields to the caller so they can be added
to a Document and indexed at the appropriate time.  But yes, you can add a stored field with
the same name and everything is fine.  We are definitely decoupling indexed and stored fields
more and more beneath IndexWriter, but to Document you can either have one Field instance
for both indexed and stored, or two different instances.
                
> Storing Shapes shouldn't be Strategy dependent
> ----------------------------------------------
>
>                 Key: LUCENE-4188
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4188
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: modules/spatial
>            Reporter: Chris Male
>
> The logic for storing Shape representations seems to be different for each Strategy.
 The PrefixTreeStrategy impls store the Shape in WKT, which is nice if you're using WKT but
not much help if you're not.  BBoxStrategy doesn't actually store the Shape itself, but a
representation of the bounding box.  TwoDoubles seems to follow the PrefixTreeStrategy approach,
which is surprising since it only indexes Points and they could be stored without using WKT.
> I think we need to consider what storing a Shape means.  If we want to store the Shape
itself, then that logic should be standardised and done outside of the Strategys since it
is not really related to them.  If we want to store the terms being used by the Strategys
to make Shapes queryable, then we need to change the logic in the Strategys to actually do
this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message