lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dawid Weiss (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3950) load rat via ivy for rat-sources task
Date Thu, 12 Jul 2012 07:00:46 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412568#comment-13412568
] 

Dawid Weiss commented on LUCENE-3950:
-------------------------------------

{code}
+    <typedef resource="org/apache/rat/anttasks/antlib.xml" uri="antlib:org.apache.rat.anttasks">
       <classpath>
-        <fileset dir="." includes="rat*.jar"/>
+        <fileset dir="${common.dir}/tools/lib" includes="apache-rat-0.8.jar"/>
       </classpath>
     </typedef>
{code}

I don't like this duplication of version numbers in ivy and ant files. I think it'd be nicer
to use ivy's fileset or path to resolve these JARs if they're not part of the distribution?

                
> load rat via ivy for rat-sources task
> -------------------------------------
>
>                 Key: LUCENE-3950
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3950
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: general/build
>            Reporter: Robert Muir
>             Fix For: 4.0, 5.0
>
>         Attachments: LUCENE-3950.patch
>
>
> we now fail the build on rat problems (LUCENE-1866),
> so we should make it easy to run rat-sources for people
> to test locally (it takes like 3 seconds total for the whole trunk)
> Also this is safer than putting rat in your ~/.ant/lib because that 
> adds some classes from commons to your ant classpath (which we currently
> wrongly use in compile).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message