lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4173) Remove IgnoreIncompatibleGeometry for SpatialStrategys
Date Sun, 15 Jul 2012 04:04:34 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414573#comment-13414573
] 

David Smiley commented on LUCENE-4173:
--------------------------------------

bq.  Is the idea to push the decision about whether to ignore or to throw an Exception, to
the consumer? I kind of like that.

Yeah, that's the inspiration.  So if you wanted to demo shapes being indexed in different
ways with different strategies, you could implement ignoreIncompatibleGeometry at the consumer
level (e.g. Solr adapter) and not have to catch an exception to find out, which would make
me cringe.

bq. Why limit this to indexing?
Right, of course -- it should apply to a query shape too.  And thinking along these lines,
perhaps this is also a way to advertise what SpatialOperation's are supported?:
{code}
SpatialOperation[] getSupportedSpatialOperations()
{code}

Just an idea.

Having said all this, and even suggested these methods for consideration, I don't think these
informational meta methods are particularly useful because about the only real use-case I
can think of is the strategy demo, which is so-so of a use-case, IMO, and consumer-level alternatives
could be added.  I think Javadoc on the Strategy is fine and should be required *anyway* --
I shouldn't have to write code or find the source to determine what operations are supported.
 To that end, I will add some documentation to these Strategies soon.

bq. Why allow Strategys to ignore Shapes at all?
I don't like it either.  And I really don't like it "automatically degrading" (e.g. convert
circle to its bbox).  -- just hand in the the bbox then, or make the degrading configurable
at the least so the user is very clear what's happening.
                
> Remove IgnoreIncompatibleGeometry for SpatialStrategys
> ------------------------------------------------------
>
>                 Key: LUCENE-4173
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4173
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: modules/spatial
>            Reporter: Chris Male
>         Attachments: LUCENE-4173.patch
>
>
> Silently not indexing anything for a Shape is not okay.  Users should get an Exception
and then they can decide how to proceed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message