lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LUCENE-4211) in LuceneTestCase.maybeWrapReader: add an asserting impl
Date Thu, 12 Jul 2012 20:41:35 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Robert Muir updated LUCENE-4211:
--------------------------------

    Attachment: LUCENE-4211.patch

Updated patch with docsEnum and docsAndPositionsEnums asserts/state machines.

Also added a AssertingDirectoryReader which ensures subreaders are wrapped with AssertingAtomicReaders.

Also wraps termvectors with AssertingFields.

TODO:
# add state machine/asserts to TermsEnum
# add an AssertingCodec that does these checks always, put it in rotation so that any code
(e.g. solr) not necessarily using newSearcher() from LuceneTestCase still gets these checks.

There is a problem with a function query and fieldcache insanity, i dont understand this FCInvisibleReader
etc goign on here:
{noformat}
ant test  -Dtestcase=TestOrdValues -Dtests.method=testReverseOrdFieldRank -Dtests.seed=E54A53902AE23DE0
-Dtests.slow=true -Dtests.locale=fr_CH -Dtests.timezone=America/Argentina/Cordoba -Dtests.file.encoding=UTF-8
{noformat}

Its possible this is unrelated to the patch...
                
> in LuceneTestCase.maybeWrapReader: add an asserting impl
> --------------------------------------------------------
>
>                 Key: LUCENE-4211
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4211
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: general/test
>            Reporter: Robert Muir
>         Attachments: LUCENE-4211.patch, LUCENE-4211.patch
>
>
> It would be nice to wrap with FIR here sometimes,
> one that returns AssertingFields, etc etc.
> This way we could check if consumers are doing bogus things (like reading nextDoc after
it returned NO_MORE_DOCS, or TermsEnum.next after its exhausted, or things like that).
> This would also be nice to catch tests that do this rather than doing
> crazy debugging over whats not really a bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message