lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <>
Subject [jira] [Updated] (LUCENE-4199) Add ANT tool to track/disallow "forbidden" method invocations
Date Mon, 09 Jul 2012 14:46:35 GMT


Uwe Schindler updated LUCENE-4199:

    Attachment: LUCENE-4199.patch

Here is the final patch for trunk merged from our heavy committing branch.

Thanks to Robert for doing all the work in fixing Lucene and Solr.

Solr's DIH is currently exclude from the checks because of SOLR-1916.

We will commit this now, as it may get outdated fast. We need to backport after that.
> Add ANT tool to track/disallow "forbidden" method invocations
> -------------------------------------------------------------
>                 Key: LUCENE-4199
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>    Affects Versions: 4.0-ALPHA
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 4.0
>         Attachments: LUCENE-4199.patch, LUCENE-4199.patch, LUCENE-4199.patch, LUCENE-4199.patch
> In LUCENE-3877 Greg Bowyer has some asm.jar-based code to inspe ct class files for System.out/err
class. I wanted to modify this code to run it in a jar-linter task on ant, so all compiled
class files are parsed and method/ctor calls to e.g. new String(byte[]) without charset are
forbidden. We would add a list of method signatures that we dont want to have (new FileReader(File),
commons.IOUtils.loadFileToString()) and this linter will throw BuildException after static
inspection, if any class file in Lucene/Solr (including line numbers) uses any method call.
> Greg's code would be changed to use visitMethodInsn visitor, very easy.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message