lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4211) in LuceneTestCase.maybeWrapReader: add an asserting impl
Date Wed, 11 Jul 2012 21:55:35 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412045#comment-13412045
] 

Uwe Schindler commented on LUCENE-4211:
---------------------------------------

I guess this is a good idea. But as said, some of those checks in your ctor should be done
in the AtomicReader impl already, as they cost nothing (same for other readers). But of course
asserting DocsEnums and TermsEnums is the real advantage of this!
                
> in LuceneTestCase.maybeWrapReader: add an asserting impl
> --------------------------------------------------------
>
>                 Key: LUCENE-4211
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4211
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: general/test
>            Reporter: Robert Muir
>         Attachments: LUCENE-4211.patch
>
>
> It would be nice to wrap with FIR here sometimes,
> one that returns AssertingFields, etc etc.
> This way we could check if consumers are doing bogus things (like reading nextDoc after
it returned NO_MORE_DOCS, or TermsEnum.next after its exhausted, or things like that).
> This would also be nice to catch tests that do this rather than doing
> crazy debugging over whats not really a bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message