lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4186) Lucene spatial's "distErrPct" is treated as a fraction, not a percent.
Date Wed, 25 Jul 2012 05:37:34 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422017#comment-13422017
] 

David Smiley commented on LUCENE-4186:
--------------------------------------

I agree on unit standardization.

Absolute distance error for a shape would be a useful option to specify to SpatialArgument
as part of the query.  It only accepts a percentage (actually fraction) now.

I agree with your concept of the ramification of optional vs non-optional as compulsory arguments
vs setters.  So:
* Add "distErrPct" distance error percent to SpatialStrategy with getter & setter, acting
as the default for index & query shapes with area.  The non-PrefixTree Strategies ignore
it since they use the full precision that a Double works out to be.  I think this should be
one of those documented things (i.e. what does the Strategy do with it).
* Add "maxDetailDist" (that name could use improvement?) with getter and setter.  Although
again, non-PrefixTree Strategies ignore it and use whatever a Double is, but this time the
setter is pointless because this specific strategy happens to require this information earlier
as part of its construction.  Maybe that could be changed?  And I think it would be neat for
the getter to return the actual max detail which will generally be greater than what you ask
for.

Despite these being used just by PrefixTreeStrategy, it seems universal in how you specify
what you want, what your spatial precision requirements are.

RE "maxDetailDist" name, maybe "smallestDist"?  Or I dunno... maybe just keep it.
                
> Lucene spatial's "distErrPct" is treated as a fraction, not a percent.
> ----------------------------------------------------------------------
>
>                 Key: LUCENE-4186
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4186
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/spatial
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Critical
>             Fix For: 4.0
>
>
> The distance-error-percent of a query shape in Lucene spatial is, in a nutshell, the
percent of the shape's area that is an error epsilon when considering search detail at its
edges.  The default is 2.5%, for reference.  However, as configured, it is read in as a fraction:
> {code:xml}
>     <fieldType name="location_2d_trie" class="solr.SpatialRecursivePrefixTreeFieldType"
>                distErrPct="0.025" maxDetailDist="0.001" />
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message