lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <>
Subject [jira] [Commented] (LUCENE-4183) Simplify CompoundFileDirectory opening in 4.x
Date Mon, 02 Jul 2012 10:46:23 GMT


Uwe Schindler commented on LUCENE-4183:

btw, the block of code in this issue is *the* classical example for above pattern! Should
I rewrite it? The code is also much shorter than the current if then else stuff in finally.
> Simplify CompoundFileDirectory opening in 4.x
> ---------------------------------------------
>                 Key: LUCENE-4183
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>    Affects Versions: 4.0
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 4.0
>         Attachments: LUCENE-4183.patch
> The compiler bug in JDK 8EA let me look at the code again. I opened bug report with simple
test case at Oracle, but the code on our side is still too complicated to understand.
> The attached path for 4.x removes the nested try-finaly block and simpliefies success=true
handling (which was in fact broken). It uses a more try-with-resources like approach with
only one finally block.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message