lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LUCENE-4211) in LuceneTestCase.maybeWrapReader: add an asserting impl
Date Wed, 11 Jul 2012 20:54:34 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Robert Muir updated LUCENE-4211:
--------------------------------

    Attachment: LUCENE-4211.patch

Here's a start to the patch, an AssertingAtomicReader.

It just needs asserts (i only added a few ones in the ctor)

It would be nice if we could also create an AssertingCompositeReader somehow, that would wrap
another composite reader and ensure its subs are wrapped with AssertingAtomicReaders?

Maybe it could also do some composite-level checks.

                
> in LuceneTestCase.maybeWrapReader: add an asserting impl
> --------------------------------------------------------
>
>                 Key: LUCENE-4211
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4211
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: general/test
>            Reporter: Robert Muir
>         Attachments: LUCENE-4211.patch
>
>
> It would be nice to wrap with FIR here sometimes,
> one that returns AssertingFields, etc etc.
> This way we could check if consumers are doing bogus things (like reading nextDoc after
it returned NO_MORE_DOCS, or TermsEnum.next after its exhausted, or things like that).
> This would also be nice to catch tests that do this rather than doing
> crazy debugging over whats not really a bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message