lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LUCENE-4183) Simplify CompoundFileDirectory opening in 4.x
Date Mon, 02 Jul 2012 11:10:22 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Uwe Schindler updated LUCENE-4183:
----------------------------------

    Attachment: LUCENE-4183-priorE-pattern.patch

For comparison, here the most correct pattern (emulated try-with-resources, java7's javac
synthetic code looks identical byte-code wise). Unfortunately for this type of method we need
the last line until Java 7. javac would otherwise complain about missing return statement
(because compiler does not know that it can never be reached).

I have no preference what to commit, comments?
                
> Simplify CompoundFileDirectory opening in 4.x
> ---------------------------------------------
>
>                 Key: LUCENE-4183
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4183
>             Project: Lucene - Java
>          Issue Type: Improvement
>    Affects Versions: 4.0
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 4.0
>
>         Attachments: LUCENE-4183-priorE-pattern.patch, LUCENE-4183.patch
>
>
> The compiler bug in JDK 8EA let me look at the code again. I opened bug report with simple
test case at Oracle, but the code on our side is still too complicated to understand.
> The attached path for 4.x removes the nested try-finaly block and simpliefies success=true
handling (which was in fact broken). It uses a more try-with-resources like approach with
only one finally block.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message