lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4246) Fix IndexWriter.close() to not commit or wait for pending merges
Date Tue, 24 Jul 2012 13:12:34 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421384#comment-13421384
] 

Shai Erera commented on LUCENE-4246:
------------------------------------

bq. Shai: look at the JDBC connection API.

I'm arguing about changing current behavior with no apparent gains. And I'm not sure that
I want to compare IW API to JDBC ... to me they are not the same things, but this may be just
semantics.

bq. I dont know what you are talking about saying OutputStream is transactional

I didn't say OS is transactional, but rather that it's not the point. The point is changing
API that works one way for years, which users rely on its behavior for years, their apps will
be broken in who knows how many ways etc etc ... again, for no apparent gains.

This is what I object to -- changing semantics of API which people are happy with and used
to it. If it's so important to you, you can make a new API closeNoCommit(). Today it's rollback(),
but if that ever changes, we have an explicit API.

And I don't understand if you argue for the sake arguing, or you really believe there is anyone
out there intending to close IW without committing the changes? Do *you* intend to do it?
                
> Fix IndexWriter.close() to not commit or wait for pending merges
> ----------------------------------------------------------------
>
>                 Key: LUCENE-4246
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4246
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>             Fix For: 4.0
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message