lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4234) Exception when FacetsCollector is used with ScoreFacetRequest
Date Sun, 22 Jul 2012 08:36:34 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420126#comment-13420126
] 

Shai Erera commented on LUCENE-4234:
------------------------------------

Ok I understand the code better now -- the scores array keeps scores only for docs that were
visited by Scorer. Therefore it doesn't need to be of size maxDoc, but rather close to how
many docs were visited.

Makes sense I guess for queries that hit a low percentage of the index. I'm not worried about
the re-allocation work at all ... I didn't dig deep into the code first, and thought that
we're keeping an entry per document in the index, whether it's scored or not.

The current code is good then.

I'll review the new patch now.
                
> Exception when FacetsCollector is used with ScoreFacetRequest
> -------------------------------------------------------------
>
>                 Key: LUCENE-4234
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4234
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: modules/facet
>    Affects Versions: 3.6, 4.0-ALPHA
>            Reporter: Gilad Barkai
>            Assignee: Shai Erera
>             Fix For: 4.0, 5.0, 3.6.2
>
>         Attachments: LUCENE-4234.patch
>
>
> Aggregating facets with Lucene's Score using FacetsCollector results in an Exception
(assertion when enabled).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message