lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LUCENE-4211) in LuceneTestCase.maybeWrapReader: add an asserting impl
Date Fri, 13 Jul 2012 12:59:34 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Robert Muir updated LUCENE-4211:
--------------------------------

    Attachment: LUCENE-4211.patch

Latest patch: I fixed up all javadocs, and also setup AssertingCodec to wrap its term vectors
with AssertingFields.

But this finds bugs in highlighter, they all look like this:

{noformat}
[junit4:junit4] Suite: org.apache.lucene.search.highlight.HighlighterPhraseTest
[junit4:junit4] FAILURE 0.07s J2 | HighlighterPhraseTest.testSparseSpan
[junit4:junit4]    > Throwable #1: java.lang.AssertionError: nextPosition() called before
nextDoc()/advance()
[junit4:junit4]    > 	at __randomizedtesting.SeedInfo.seed([A46A143B772103ED:932787705C50F42E]:0)
[junit4:junit4]    > 	at org.apache.lucene.index.AssertingAtomicReader$AssertingDocsAndPositionsEnum.nextPosition(AssertingAtomicReader.java:325)
[junit4:junit4]    > 	at org.apache.lucene.search.highlight.TokenSources.hasPositions(TokenSources.java:131)
[junit4:junit4]    > 	at org.apache.lucene.search.highlight.TokenSources.getTokenStream(TokenSources.java:170)
[junit4:junit4]    > 	at org.apache.lucene.search.highlight.HighlighterPhraseTest.testSparseSpan(HighlighterPhraseTest.java:272)
{noformat}
                
> in LuceneTestCase.maybeWrapReader: add an asserting impl
> --------------------------------------------------------
>
>                 Key: LUCENE-4211
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4211
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: general/test
>            Reporter: Robert Muir
>         Attachments: LUCENE-4211.patch, LUCENE-4211.patch, LUCENE-4211.patch, LUCENE-4211.patch,
LUCENE-4211.patch
>
>
> It would be nice to wrap with FIR here sometimes,
> one that returns AssertingFields, etc etc.
> This way we could check if consumers are doing bogus things (like reading nextDoc after
it returned NO_MORE_DOCS, or TermsEnum.next after its exhausted, or things like that).
> This would also be nice to catch tests that do this rather than doing
> crazy debugging over whats not really a bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message