lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LUCENE-4230) When pulling DocsAndPositionsEnum you should state whether you need payloads
Date Mon, 30 Jul 2012 15:05:35 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-4230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Robert Muir updated LUCENE-4230:
--------------------------------

    Attachment: LUCENE-4230.patch

updated patch: I simplified tests to just call dpEnum(Bits, reuse) instead of passing flags.

Basically I think tests should just work on 'whats there', and we should fix newField such
that we sometimes 'add extra stuff in addition to what the test needs'.

This not only simplifies our code but will maximize test coverage. I'm resisting the urge
to beef up TestDuelingCodecs... another issue for that :)

Separately I added some nocommits while reviewing the code: places where we are still conditionalizing
the code based on a null result (which wont happen). 
                
> When pulling DocsAndPositionsEnum you should state whether you need payloads
> ----------------------------------------------------------------------------
>
>                 Key: LUCENE-4230
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4230
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 5.0
>
>         Attachments: LUCENE-4230.patch, LUCENE-4230.patch, LUCENE-4230.patch, LUCENE-4230.patch
>
>
> Payloads are extra-costly today because when pulling a
> DocsAndPositionsEnum, the codec has no way to know if you need access
> to the payloads.  Tracking the payloads, even if the app never
> retrieves them, is often costly...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message