lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-3595) Currency types do not support range queries when multiValued
Date Sat, 28 Jul 2012 00:41:34 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424237#comment-13424237
] 

Hoss Man commented on SOLR-3595:
--------------------------------

bq. I'd prefer to "fail early, fail often" and catch this when the schema file was being parsed,
but I don't see a convenient place to do that. Am I overlooking the obvious again?

can't we just put hte logic in CurrencyField.init(), after the call to super.init() ... 

{code}
if (this.isMultiValued()) { 
 throw new SolrException("CurrencyField's can not be multivalued: " + this.typeName) 
} 
{code}

?

(see BadIndexSchemaTest for an example of how to test that it fails properly)
                
> Currency types do not support range queries when multiValued
> ------------------------------------------------------------
>
>                 Key: SOLR-3595
>                 URL: https://issues.apache.org/jira/browse/SOLR-3595
>             Project: Solr
>          Issue Type: Bug
>          Components: Schema and Analysis
>    Affects Versions: 4.0-ALPHA
>            Reporter: Erick Erickson
>            Priority: Minor
>              Labels: CurrencyField
>             Fix For: 4.0
>
>
> You can define the currency type as multiValued. However, if you do (and have more than
one value), range queries, at least, do not work. See the thread titled "Filtering a query
by range returning unexpected results".
> I'm not at all sure that currency type _should_ support multivalued. For instance, how
would one handle storing multiple values for a currency type in different currencies (e.g.
USD and EUR)? I don't know enough about the internals to understand if it's possible, this
JIRA is the result of a question on the users list.
> If we decide that currency should _not_ support multiValued, it seems a check at startup
is in order on the "fail early, fail loudly" principle.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message