lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4202) allow check-forbidden-apis to look for fields too
Date Tue, 10 Jul 2012 09:07:34 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410147#comment-13410147
] 

Uwe Schindler commented on LUCENE-4202:
---------------------------------------

bq. Separately we could open an issue to deal with this virtual problem? It just means our
checker isn't as thorough as it is, but none of our checkers/tests are perfect.

Yes it is not as thorough for things like Throwable.printStackTrace(), but for the JVM's deprecated
list, we should still catch almost all, as the deprecated list in the JVM is complete (it
also should list subclasses - if method is overridded).

For the original checks we did at beginning (encoding, locale,... problems), this was also
thorough enough, as we listed all calls that may be used. If a custom subclass in Lucene code
would subclass this system class and modify a "forbidden method", the "super" call would trigger
the violation report.

I think this is ready to commit, Robert can you check with Apache RAT installed?
                
> allow check-forbidden-apis to look for fields too
> -------------------------------------------------
>
>                 Key: LUCENE-4202
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4202
>             Project: Lucene - Java
>          Issue Type: New Feature
>          Components: general/build
>            Reporter: Robert Muir
>            Assignee: Uwe Schindler
>         Attachments: LUCENE-4202.patch, LUCENE-4202.patch
>
>
> Currently this supports classes and methods, but there are some deprecated fields in
the java API, it would be nice to check for those, too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message