lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-3604) The wiki claims all comments are wiped from solr.xml on save - we should fix this.
Date Sun, 08 Jul 2012 16:15:34 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408949#comment-13408949
] 

Mark Miller commented on SOLR-3604:
-----------------------------------

I work on a product that has a class that edits solrconfig.xml and schema.xml. We keep the
DOM tree around and edit it directly for modifications - later we serialize it out with changes,
preserving comments. It seems to work out just fine - at the least it turns out a lot better
than just stripping the comments.

We should be doing the same thing here with solr.xml - the starting comments contain very
helpful information for manual editing, and users may add their own comments.

I'm not sure why we do any XML writing manually - I have no problem replacing that.

                
> The wiki claims all comments are wiped from solr.xml on save - we should fix this.
> ----------------------------------------------------------------------------------
>
>                 Key: SOLR-3604
>                 URL: https://issues.apache.org/jira/browse/SOLR-3604
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>            Priority: Minor
>             Fix For: 4.0, 5.0
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message