lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Miller <markrmil...@gmail.com>
Subject Re: [jira] [Commented] (SOLR-3654) Add some tests using Tomcat as servlet container
Date Mon, 23 Jul 2012 02:34:02 GMT
Either the tests will be good and almost everything will be tested in other containers - this
has a huge cost. We get really deep into jetty in our tests. Ive had to spend countless hours
getting tests to behave with jetty. Adding in more containers would make a ton more complications
an work.   Better spent on other things that will attract more users. 

Or the tests will be super minimal and give a false sense of security. 

I'd rather focus on making one great search engine over properly supporting N containers.
N containers has an exponential cost in my Solr dev experience - if you were to fully test
them as we do jetty. 

One container is all you need :)

Sent from my iPhone

On Jul 22, 2012, at 10:16 PM, Bill Bell <billnbell@gmail.com> wrote:

> Testing a bunch of containers will give Solr a larger user base. All good right?
> 
> Bill Bell
> Sent from mobile
> 
> 
> On Jul 20, 2012, at 6:51 AM, "Mark Miller (JIRA)" <jira@apache.org> wrote:
> 
>> 
>>   [ https://issues.apache.org/jira/browse/SOLR-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13419097#comment-13419097
] 
>> 
>> Mark Miller commented on SOLR-3654:
>> -----------------------------------
>> 
>> I'm 100% against this. 
>> 
>>> Add some tests using Tomcat as servlet container
>>> ------------------------------------------------
>>> 
>>>               Key: SOLR-3654
>>>               URL: https://issues.apache.org/jira/browse/SOLR-3654
>>>           Project: Solr
>>>        Issue Type: Task
>>>        Components: Build
>>>       Environment: Tomcat
>>>          Reporter: Jan H√łydahl
>>>            Labels: Tomcat
>>>           Fix For: 4.0
>>> 
>>> 
>>> All tests use Jetty, we should add some tests for at least one other servlet
container (Tomcat). Ref discussion at http://search-lucene.com/m/6mo9Y1WZaWR1
>> 
>> --
>> This message is automatically generated by JIRA.
>> If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>> 
>> 
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message