Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Wed, 20 Jun 2012 10:08:43 +0000 (UTC)
From: "Shai Erera (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: <594381509.33388.1340186923092.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <2025913505.28704.1340090204339.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (LUCENE-4156) Improve implementation of
 DirectoryTaxonomyWriter.getSize()
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/LUCENE-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397399#comment-13397399 ] 

Shai Erera commented on LUCENE-4156:
------------------------------------

You're right, 2 extra method calls are not worth the defensive code. If we'll change getSize(), I hope that we'll remember to fix getParent too. At any rate, the reason we check the size is for throwing a friendlier exception with text. If someone passes an invalid ordinal, he'll get AIOOBE anyway, just without the text.

I'll commit this now.
                
> Improve implementation of DirectoryTaxonomyWriter.getSize()
> -----------------------------------------------------------
>
>                 Key: LUCENE-4156
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4156
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: modules/facet
>            Reporter: Sivan Yogev
>            Assignee: Shai Erera
>            Priority: Minor
>         Attachments: LUCENE-4156.patch
>
>
> Current implementation of DirectoryTaxonomyWriter.getSize() is synchrionized and invokes indexWriter.maxDoc(), both harming performance.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org