Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 127F29835 for ; Sun, 10 Jun 2012 11:44:46 +0000 (UTC) Received: (qmail 42350 invoked by uid 500); 10 Jun 2012 11:44:45 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 42161 invoked by uid 500); 10 Jun 2012 11:44:44 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 42131 invoked by uid 99); 10 Jun 2012 11:44:43 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 10 Jun 2012 11:44:43 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id EFFBD1404B4 for ; Sun, 10 Jun 2012 11:44:42 +0000 (UTC) Date: Sun, 10 Jun 2012 11:44:42 +0000 (UTC) From: "Shai Erera (JIRA)" To: dev@lucene.apache.org Message-ID: <1020683960.1178.1339328682985.JavaMail.jiratomcat@issues-vm> In-Reply-To: <586091106.3256.1337155862454.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Reopened] (LUCENE-4061) Improvements to DirectoryTaxonomyWriter (synchronization and others) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-4061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera reopened LUCENE-4061: -------------------------------- TestDirectoryTaxonomyWriter.testConcurrency sometimes fails on mismatch number of categories. This is not repeated easily, but if run with -Dtests.iters, it is. > Improvements to DirectoryTaxonomyWriter (synchronization and others) > -------------------------------------------------------------------- > > Key: LUCENE-4061 > URL: https://issues.apache.org/jira/browse/LUCENE-4061 > Project: Lucene - Java > Issue Type: Improvement > Components: modules/facet > Reporter: Shai Erera > Assignee: Shai Erera > Fix For: 4.0 > > Attachments: LUCENE-4061.patch > > > DirTaxoWriter synchronizes in too many places. For instance addCategory() is fully synchronized, while only a small part of it needs to be. > Additionally, getCacheMemoryUsage looks bogus - it depends on the type of the TaxoWriterCache. No code uses it, so I'd like to remove it -- whoever is interested can query the specific cache impl it has. Currently, only Cl2oTaxoWriterCache supports it. > If the changes will be simple, I'll port them to 3.6.1 as well. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org