Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id ECFCE9971 for ; Sun, 3 Jun 2012 07:53:59 +0000 (UTC) Received: (qmail 20833 invoked by uid 500); 3 Jun 2012 07:53:58 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 20729 invoked by uid 500); 3 Jun 2012 07:53:57 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 20711 invoked by uid 99); 3 Jun 2012 07:53:57 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 03 Jun 2012 07:53:57 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of uwe@thetaphi.de designates 188.138.97.18 as permitted sender) Received: from [188.138.97.18] (HELO mail.sd-datasolutions.de) (188.138.97.18) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 03 Jun 2012 07:53:48 +0000 Received: from VEGA (port-92-196-65-14.dynamic.qsc.de [92.196.65.14]) by mail.sd-datasolutions.de (Postfix) with ESMTPSA id 8663F14AA266 for ; Sun, 3 Jun 2012 07:53:27 +0000 (UTC) From: "Uwe Schindler" To: References: In-Reply-To: Subject: RE: Suppressing list doesn't take effect when -Dtests.postingsformat is used Date: Sun, 3 Jun 2012 09:54:09 +0200 Message-ID: <001501cd415e$0f07e7c0$2d17b740$@thetaphi.de> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQKJWaQ2VUbauPz0odCmqznQ5CAIwgLVnpt3lVlbSQA= Content-Language: de > The actual source of the problem is that suppression applies to = codec.getName > and enforcing a TEST_POSTINGSFORMAT means Lucene40Codec is created > which always returns Lucene40 from getName(). A simple fix would be to = allow > changing the returned name for Lucene40. I don't think we should do this! Making it un-final destroys the whole = concept behind it. SPI relies on a constant name and this enforces the = codec API to behave correctly. If it can suddenly return a different = name the consistency between codec file format and loaded codec is no = longer preserved. Uwe --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org