lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dawid Weiss <dawid.we...@cs.put.poznan.pl>
Subject Re: svn commit: r1354361 - /lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/analysis/BaseTokenStreamTestCase.java
Date Thu, 28 Jun 2012 09:18:43 GMT
> P.S.: And now please also wrap with Collections.unmodifiableSet() :-)

Subclass-style initialization may look fancy in code but generates an
additional .class file and in general is not clear to somebody who
isn't familiar with the trick.

The fact it's not a constant doesn't bother me that much as it's a test class.

Dawid

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message