lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael McCandless <luc...@mikemccandless.com>
Subject Re: svn commit: r1351829 - in /lucene/dev/trunk/lucene: analysis/kuromoji/src/test/org/apache/lucene/analysis/ja/TestJapaneseTokenizer.java test-framework/src/java/org/apache/lucene/analysis/BaseTokenStreamTestCase.java
Date Tue, 19 Jun 2012 22:27:28 GMT
On Tue, Jun 19, 2012 at 6:18 PM, Robert Muir <rcmuir@gmail.com> wrote:
> On Tue, Jun 19, 2012 at 6:13 PM, Michael McCandless
> <lucene@mikemccandless.com> wrote:
>> Ahhh good point: using the annotation, LuceneTestCase will simply pick
>> a codec that's allowed, and the test runs.
>>
>> But using an Assume somewhere inside means ... LuceneTestCase can pick
>> the "wrong" codec and then silently the test doesn't run.
>>
>> And, I hadn't realized I can add the annot to BaseTokenStreamTestCase
>> and all tests inheriting from it will respect that.  Though I guess
>> that means any test inheriting from BTSTC and not using
>> checkRandomData with biggish args loses some test coverage ... but
>> that seems the lesser evil here.
>
> Looking at your commit, i fixed it with a different approach: if your
> logic doesn't match, we just dont index anything (but still test the
> actual analyzer).

Ahh I like that solution!

And I agree we should avoid Assume: it's dangerous.

Mike McCandless

http://blog.mikemccandless.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message