lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martijn v Groningen <martijn.v.gronin...@gmail.com>
Subject Re: remove "via"
Date Wed, 06 Jun 2012 16:25:24 GMT
+1 to remove the via. If someone has done work other then reviewing
and committing then he could add himself as one of the author (Order
is important; contributor first then committer. Depending on the work
done).

Maybe the contributors that have contributed in a release can also be
highlighted inside the release notes? (Just like improvements and
features are highlighted) Tika lists all people (committers and
contributors) that have contributed inside the changes.txt. I think
this will be a nice gesture.

Martijn

On 6 June 2012 15:44, Uwe Schindler <uwe@thetaphi.de> wrote:
> Hi Eric,
>
> I agree 100% with you, we should keep "via".
>
> Uwe
>
> -----
> Uwe Schindler
> H.-H.-Meier-Allee 63, D-28213 Bremen
> http://www.thetaphi.de
> eMail: uwe@thetaphi.de
>
>
>> -----Original Message-----
>> From: Eric Pugh [mailto:epugh@opensourceconnections.com]
>> Sent: Wednesday, June 06, 2012 2:33 PM
>> To: dev@lucene.apache.org
>> Subject: Re: remove "via"
>>
>> I've looked at the "via" in the changelog to figure out which committer
> works in
>> which areas the most, and therefore who to ping about a patch.  And I do
> think
>> that shepherding a patch file through to commit is worthy of some credit.
> It's
>> often a fair amount of work to evaluate a patch file, offer constructive
>> suggestions to someone who may not be familiar with how the process works,
>> and eventually get it committed.  And it's often fairly thankless since
> you
>> typically are helping someone else scratch their itch, not your own!
>>
>>
>> On Jun 6, 2012, at 8:14 AM, Mark Miller wrote:
>>
>> >
>> > On Jun 5, 2012, at 6:40 PM, Robert Muir wrote:
>> >
>> >> Opinions?
>> >
>> > I disagree - I think it makes it really easy to track who actually did
> the commit
>> (the person *responsible* if it's a bad commit or a good commit) and I
> think
>> there is some credit in a committer applying someones patch. They are
> doing
>> the review and taking responsibility for the code change. I think *via* is
> pretty
>> clear regarding credit, and I think it has value in it's information. Even
> if you
>> simply commit someone else work, *you* are contributing to the issue. You
>> better have reviewed it, you better be willing to take responsibility for
> it.
>> >
>> > Appears I'm in the strong minority though.
>> >
>> > - Mark Miller
>> > lucidimagination.com
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For
>> > additional commands, e-mail: dev-help@lucene.apache.org
>> >
>>
>> -----------------------------------------------------
>> Eric Pugh | Principal | OpenSource Connections, LLC | 434.466.1467 |
>> http://www.opensourceconnections.com
>> Co-Author: Apache Solr 3 Enterprise Search Server available from
>> http://www.packtpub.com/apache-solr-3-enterprise-search-server/book
>>
>> This e-mail and all contents, including attachments, is considered to be
>> Company Confidential unless explicitly stated otherwise, regardless of
> whether
>> attachments are marked as such.
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional
>> commands, e-mail: dev-help@lucene.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>



-- 
Met vriendelijke groet,

Martijn van Groningen

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message