lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4146) -Dtests.iters combined with -Dtestmethod never fails?
Date Fri, 15 Jun 2012 15:58:43 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295735#comment-13295735
] 

Hoss Man commented on LUCENE-4146:
----------------------------------

I can't comment on how anything works in any IDEs, so I'll take your word for it -- but from
a command line standpoint it's really confusing, particularly since "test-help" actually says
this combo should work...

{noformat}
     [echo] # Repeats a given test N times (note filters).
     [echo] ant test -Dtests.iters=N -Dtestcase=ClassName -Dtestmethod=mytest
{noformat}

It seems like we should do the following...

* change the code path that reads the system properties used to pick the tests to fail if
this combination (tests.iters + a non-globed "test method") is used (rather then silently
lying and saying (0) tests passed)
* change "-Dtestmethod=XXX" so that instead of being an alias for "-Dtests.method=XXX" it
becomes an alias for "-Dtests.method=XXX*" (similar to how "-D=testcase=XXX" is an alias for
"-Dtests.class=*.XXX")

Or at the very least...

* fix test-help to not suggest something guaranteed to not work :)  





                
> -Dtests.iters combined with -Dtestmethod never fails?
> -----------------------------------------------------
>
>                 Key: LUCENE-4146
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4146
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Hoss Man
>         Attachments: LUCENE-4146.fail.patch, TEST-org.apache.lucene.TestSearch.iters-no-fail.xml,
TEST-org.apache.lucene.TestSearch.no-iters-fail.xml
>
>
> a test that is hardcoded to fail will report succes if you run it with -Dtests.iters

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message