lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Male (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4167) Remove the use of SpatialOperation
Date Thu, 28 Jun 2012 12:34:44 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403055#comment-13403055
] 

Chris Male commented on LUCENE-4167:
------------------------------------

{quote}
makeFilter & makeQuery receives a SpatialArgs object which has already been parsed; it's
not a string anymore. (The "Command" design pattern, by the way). And he's also proposing
that SpatialArgs is gone, at least from these methods, and instead you get a Shape + distancePrecision
pair of args.
{quote}

I gather you don't like that idea, it reads that way at least.  

We don't need SpatialArgs at the moment.  It feels like a hack to allow us to add whatever
arguments we want without having to change method signature and so we can have some defaults.
 The Strategy API should be explicit so users know exactly what they need to provide (distance
precision is used in both of the PrefixTreeStrategys, it is important) and we should consider
any changes to the API very carefully.  This API shouldnt have any mystery or surprises, it
should be extremely clear to what user what to expect.  I cannot stress this enough.
                
> Remove the use of SpatialOperation
> ----------------------------------
>
>                 Key: LUCENE-4167
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4167
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: modules/spatial
>            Reporter: Chris Male
>         Attachments: LUCENE-4167.patch
>
>
> Looking at the code in TwoDoublesStrategy I noticed SpatialOperations.BBoxWithin vs isWithin
which confused me.  Looking over the other Strategys I see that really only isWithin and Intersects
is supported.  Only TwoDoublesStrategy supports IsDisjointTo.  The remainder of SpatialOperations
are not supported.
> I don't think we should use SpatialOperation as this stage since it is not clear what
Operations are supported by what Strategys, many Operations are not supported, and the code
for handling the Operations is usually the same.  We can spin off the code for TwoDoublesStrategy's
IsDisjointTo support into a different Strategy.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message