lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4126) Remove FieldType copy constructor
Date Sat, 09 Jun 2012 14:15:43 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292346#comment-13292346
] 

Robert Muir commented on LUCENE-4126:
-------------------------------------

{quote}
Currently specifying your own FieldType means you have to use Field rather than StringField
or TextField as neither of them accept a FieldType. This is messy and basically the same problem
that LUCENE-4101 is fixing for storing. Hmm..
{quote}

Actually i think this is ok: these are still expertish things but just not totally crazy.

I dont understand the benefit removing this: having someone create a FieldType from scratch
is crazy. Its way too ridiculous: too easy to forget to set tokenized to true or whatever.
Creating a FieldType from scratch is pretty much only useful for committers or people extending
things in super-expert ways.

So I think its clear whats best: we have to keep lucene useable.
                
> Remove FieldType copy constructor
> ---------------------------------
>
>                 Key: LUCENE-4126
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4126
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Chris Male
>             Fix For: 4.0, 5.0
>
>
> Currently FieldTypes can be created using new FieldType(someOtherFieldType) which copies
the properties and allows them to then changed.  This reduces readability since it hides what
properties someOtherFieldType has enabled.  We should encourage users (and ourselves) to explicitly
state what properties are enabled so to prevent any surprises. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message