lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrzej Bialecki ...@getopt.org>
Subject Re: remove "via"
Date Wed, 06 Jun 2012 17:07:00 GMT
On 06/06/2012 00:40, Robert Muir wrote:
> Hello,
>
> Currently we do this in CHANGES.txt:
>
> LUCENE-XXXX:
>    Fixed a horrible nasty bug. (Joe Contributor via John Doe Committer)
>
> I propose we remove "via<committers name>" from CHANGES.txt. I don't
> think any users care about who committed changes and I think it
> de-emphasizes the actual contributor. If we need to know who committed
> something we can find this in SVN logs or on the jira issue.
>
> Opinions?

-1 for pretty much the same reasons as Mark and Eric listed - some work 
is required even for trivial patches, and it also helps to quickly see 
which committer was involved in reviewing and signing-off on an issue 
(not always obvious from JIRA).

-- 
Best regards,
Andrzej Bialecki
http://www.sigram.com, blog http://www.sigram.com/blog
  ___.,___,___,___,_._. __________________<><____________________
[___||.__|__/|__||\/|: Information Retrieval, System Integration
___|||__||..\|..||..|: Contact: info at sigram dot com


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message